Add Gemini CLI provider#131
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6734d872c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| reviewer: ['claude', 'codex', 'openrouter'], | ||
| executor: ['claude', 'codex', 'openrouter'], | ||
| verifier: ['claude', 'codex', 'openrouter'], | ||
| planner: [...PIPELINE_EXECUTOR_PROVIDERS], |
There was a problem hiding this comment.
Adding PIPELINE_EXECUTOR_PROVIDERS here now exposes gemini in issue-level phase override selectors, but the main-process handler for github:set-phase-model-override still rejects anything except claude|codex|openrouter (apps/desktop/src/main/ipc/register-github-handlers.ts:1133-1134). Selecting Gemini in the UI therefore throws Invalid <phase> model and the override cannot be saved, so the newly added option is non-functional in this workflow.
Useful? React with 👍 / 👎.
| function assertProcessManagerCommand(command: string): asserts command is ProcessManagerCommand { | ||
| if (isTrustedShell(command) || isAllowlistedAgentCommand(command)) return; | ||
| throw new Error(`Command is not allowlisted for ProcessManager: ${command}`); |
There was a problem hiding this comment.
This new assertion rejects any command not in the allowlist, which now includes shell paths; however instant:bare-shell launches process.env.SHELL (apps/desktop/src/main/ipc/register-instant-handlers.ts:472-476). Users whose login shell is not one of the hardcoded entries (for example fish) will now get Command is not allowlisted for ProcessManager and cannot open a bare terminal session, which worked before this change because non-agent commands bypassed allowlist checks.
Useful? React with 👍 / 👎.
1 participant
Opened from existing remote branch
ship/48-add-gemini-cli-providerfor review and CI monitoring.